Move diagnostics from sfc_diff to sfc_diag#2
Move diagnostics from sfc_diff to sfc_diag#2wlanghans wants to merge 2 commits intowolfgang/rebase_sofar-071124_on_mainfrom
Conversation
…ostic output and sfcprop; fix bug in computation of 10-m neutral wind components
wlanghans
changed the title
There was a problem hiding this comment.
We'll need to test this in an experiment before merging. At a minimum, we should verify the impacts are either positive or negligible on one or more test dates.
Please retain and keep track of any lines added by Sofar via comments, since we may eventually merge this into GFDL's branch.
Why do we need comments on what lines are from Sofar? If we merge into another branch/fork than the commit that gets merged will show what got added in that PR. Isn't that the beauty of having a versioning system like git? Commenting is not really clean coding according to the clean code bible, mostly because it means you have to maintain those comments plus it adds redundancy since it's tracked through git. |
2 participants
Description
This moves the computation of surface diagnostics into the sfc_diag subroutine. This routine is used to provide 10 m winds and 10-m neutral winds. Originally, winds were computed in sfc_diff and stored in sfcprop thereby using not the final similar functions. With this PR the 10-m winds in sfcprop will be computed in sfc_diag using the correct final similarity functions. The winds are thus identical to those used for diagnostic purposes.
Fixes # (issue)
How Has This Been Tested?
Not yet.
Checklist:
Please check all whether they apply or not